Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add image viewbox clipping #16

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

luke1188
Copy link
Contributor

@luke1188 luke1188 commented Apr 5, 2024

adds back viewbox clipping

Copy link
Member

@simbleau simbleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was probably a mistake to include "frame_for_time" so let's remove that, then we can merge this.

src/runtime/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@simbleau simbleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@DJMcNab
Copy link
Member

DJMcNab commented Apr 6, 2024

I've re-run the CI, as the failure looked spurious

@simbleau, how do you want this PR to be merged? I'd suggest that you just press the green button yourself

@simbleau
Copy link
Member

simbleau commented Apr 6, 2024

I'll merge it tomorrow, when i have time to add to the changelog and release a patch version (0.1.1)

I consider the lack of viewbox clipping to be a bug, since many Lotties depend on it.

@simbleau simbleau merged commit 75284b3 into linebender:main Apr 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants